FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
129 39 0 0

org.codehaus.plexus.archiver.AbstractArchiver

Bug Category Details Line Priority
Possible null pointer dereference in org.codehaus.plexus.archiver.AbstractArchiver.asResourceCollection(ArchivedFileSet, Charset) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 703 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.codehaus.plexus.archiver.AbstractArchiver.setDestFile(File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 673 Medium

org.codehaus.plexus.archiver.AbstractUnArchiver

Bug Category Details Line Priority
org.codehaus.plexus.archiver.AbstractUnArchiver.getFileSelectors() may expose internal representation by returning AbstractUnArchiver.fileSelectors MALICIOUS_CODE EI_EXPOSE_REP 231 Medium
org.codehaus.plexus.archiver.AbstractUnArchiver.setFileSelectors(FileSelector[]) may expose internal representation by storing an externally mutable object into AbstractUnArchiver.fileSelectors MALICIOUS_CODE EI_EXPOSE_REP2 225 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.codehaus.plexus.archiver.AbstractUnArchiver.extractFile(File, File, InputStream, String, Date, boolean, Integer, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 322 Medium
Exceptional return value of java.io.File.setLastModified(long) ignored in org.codehaus.plexus.archiver.AbstractUnArchiver.extractFile(File, File, InputStream, String, Date, boolean, Integer, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 350 Medium

org.codehaus.plexus.archiver.Archiver

Bug Category Details Line Priority
org.codehaus.plexus.archiver.Archiver.DUPLICATES_VALID_BEHAVIORS should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 57 Medium

org.codehaus.plexus.archiver.DotDirectiveArchiveFinalizer

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.archiver.DotDirectiveArchiveFinalizer.finalizeArchiveCreation(Archiver): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 55 High

org.codehaus.plexus.archiver.diags.NoOpArchiver$1

Bug Category Details Line Priority
org.codehaus.plexus.archiver.diags.NoOpArchiver$1.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 277 Medium

org.codehaus.plexus.archiver.diags.TrackingArchiver$Addition

Bug Category Details Line Priority
new org.codehaus.plexus.archiver.diags.TrackingArchiver$Addition(TrackingArchiver, Object, String, String[], String[], int) may expose internal representation by storing an externally mutable object into TrackingArchiver$Addition.excludes MALICIOUS_CODE EI_EXPOSE_REP2 373 Medium
new org.codehaus.plexus.archiver.diags.TrackingArchiver$Addition(TrackingArchiver, Object, String, String[], String[], int) may expose internal representation by storing an externally mutable object into TrackingArchiver$Addition.includes MALICIOUS_CODE EI_EXPOSE_REP2 372 Medium
Should org.codehaus.plexus.archiver.diags.TrackingArchiver$Addition be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 327-376 Medium

org.codehaus.plexus.archiver.dir.DirectoryArchiver

Bug Category Details Line Priority
Exceptional return value of java.io.File.setLastModified(long) ignored in org.codehaus.plexus.archiver.dir.DirectoryArchiver.setFileModes(ArchiveEntry, File, long) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 197 Medium

org.codehaus.plexus.archiver.filters.JarSecurityFileFilter

Bug Category Details Line Priority
org.codehaus.plexus.archiver.filters.JarSecurityFileFilter.SECURITY_FILE_PATTERNS should be package protected MALICIOUS_CODE MS_PKGPROTECT 15 Medium

org.codehaus.plexus.archiver.filters.JarSecurityFileSelector

Bug Category Details Line Priority
org.codehaus.plexus.archiver.filters.JarSecurityFileSelector.SECURITY_FILE_PATTERNS should be package protected MALICIOUS_CODE MS_PKGPROTECT 31 Medium

org.codehaus.plexus.archiver.jar.JarArchiver

Bug Category Details Line Priority
Field only ever set to null: org.codehaus.plexus.archiver.jar.JarArchiver.originalManifest CORRECTNESS UWF_NULL_FIELD 343 Medium

org.codehaus.plexus.archiver.jar.JdkManifestFactory

Bug Category Details Line Priority
org.codehaus.plexus.archiver.jar.JdkManifestFactory.mergeAttributes(Attributes, Attributes) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 116 Medium

org.codehaus.plexus.archiver.jar.Manifest

Bug Category Details Line Priority
org.codehaus.plexus.archiver.jar.Manifest doesn't override java.util.jar.Manifest.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
The class name org.codehaus.plexus.archiver.jar.Manifest shadows the simple name of the superclass java.util.jar.Manifest BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 52-1010 High
org.codehaus.plexus.archiver.jar.Manifest.toString() may return null BAD_PRACTICE NP_TOSTRING_COULD_RETURN_NULL 902 Medium

org.codehaus.plexus.archiver.jar.Manifest$Attribute

Bug Category Details Line Priority
Possible null pointer dereference of lhsKey in org.codehaus.plexus.archiver.jar.Manifest$Attribute.equals(Object) CORRECTNESS NP_NULL_ON_SOME_PATH 210 Medium
org.codehaus.plexus.archiver.jar.Manifest$Attribute.getValue() concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 286 Medium

org.codehaus.plexus.archiver.jar.Manifest$ExistingAttribute

Bug Category Details Line Priority
org.codehaus.plexus.archiver.jar.Manifest$ExistingAttribute doesn't override Manifest$Attribute.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.codehaus.plexus.archiver.tar.TarArchiver$TarOptions

Bug Category Details Line Priority
Should org.codehaus.plexus.archiver.tar.TarArchiver$TarOptions be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 354-461 Medium

org.codehaus.plexus.archiver.util.AbstractFileSet

Bug Category Details Line Priority
org.codehaus.plexus.archiver.util.AbstractFileSet.getExcludes() may expose internal representation by returning AbstractFileSet.excludes MALICIOUS_CODE EI_EXPOSE_REP 60 Medium
org.codehaus.plexus.archiver.util.AbstractFileSet.getFileSelectors() may expose internal representation by returning AbstractFileSet.fileSelectors MALICIOUS_CODE EI_EXPOSE_REP 75 Medium
org.codehaus.plexus.archiver.util.AbstractFileSet.getIncludes() may expose internal representation by returning AbstractFileSet.includes MALICIOUS_CODE EI_EXPOSE_REP 90 Medium
org.codehaus.plexus.archiver.util.AbstractFileSet.setExcludes(String[]) may expose internal representation by storing an externally mutable object into AbstractFileSet.excludes MALICIOUS_CODE EI_EXPOSE_REP2 54 Medium
org.codehaus.plexus.archiver.util.AbstractFileSet.setFileSelectors(FileSelector[]) may expose internal representation by storing an externally mutable object into AbstractFileSet.fileSelectors MALICIOUS_CODE EI_EXPOSE_REP2 69 Medium
org.codehaus.plexus.archiver.util.AbstractFileSet.setIncludes(String[]) may expose internal representation by storing an externally mutable object into AbstractFileSet.includes MALICIOUS_CODE EI_EXPOSE_REP2 84 Medium

org.codehaus.plexus.archiver.util.FilePermissionUtils

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.codehaus.plexus.archiver.util.FilePermissionUtils.getFilePermissionFromMode(String, Logger) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 67 High

org.codehaus.plexus.archiver.zip.AbstractZipArchiver

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipDir(PlexusIoResource, ConcurrentJarCreator, String, int, String): String.getBytes() I18N DM_DEFAULT_ENCODING 642 High
Unread field: org.codehaus.plexus.archiver.zip.AbstractZipArchiver.duplicate; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 94 Medium
Unread public/protected field: org.codehaus.plexus.archiver.zip.AbstractZipArchiver.addingNewFiles STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 100 Medium

org.codehaus.plexus.archiver.zip.ByteArrayOutputStream

Bug Category Details Line Priority
org.codehaus.plexus.archiver.zip.ByteArrayOutputStream.toBufferedInputStream(InputStream, int) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 380 Medium

org.codehaus.plexus.archiver.zip.DeferredScatterOutputStream

Bug Category Details Line Priority
Exceptional return value of java.io.File.delete() ignored in org.codehaus.plexus.archiver.zip.DeferredScatterOutputStream.close() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 59 Medium

org.codehaus.plexus.archiver.zip.OffloadingOutputStream

Bug Category Details Line Priority
Unread field: org.codehaus.plexus.archiver.zip.OffloadingOutputStream.closed PERFORMANCE URF_UNREAD_FIELD 73 Medium

org.codehaus.plexus.archiver.zip.PlexusIoZipFileResourceCollection

Bug Category Details Line Priority
org.codehaus.plexus.archiver.zip.PlexusIoZipFileResourceCollection.getEntries() creates a org.codehaus.plexus.archiver.zip.PlexusIoZipFileResourceCollection$1 classloader, which should be performed within a doPrivileged block MALICIOUS_CODE DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED 72 Medium

org.codehaus.plexus.components.io.resources.PlexusIoZipFileResourceCollection

Bug Category Details Line Priority
The class name org.codehaus.plexus.components.io.resources.PlexusIoZipFileResourceCollection shadows the simple name of the superclass org.codehaus.plexus.archiver.zip.PlexusIoZipFileResourceCollection BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 22 High