FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
104 74 0 0

org.codehaus.plexus.util.AbstractScanner

Bug Category Details Line Priority
org.codehaus.plexus.util.AbstractScanner.DEFAULTEXCLUDES should be package protected MALICIOUS_CODE MS_PKGPROTECT 54 Medium

org.codehaus.plexus.util.Base64

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.util.Base64.<static initializer for Base64>(): String.getBytes() I18N DM_DEFAULT_ENCODING 54 High

org.codehaus.plexus.util.ExceptionUtils

Bug Category Details Line Priority
org.codehaus.plexus.util.ExceptionUtils.CAUSE_METHOD_NAMES should be package protected MALICIOUS_CODE MS_PKGPROTECT 92 Medium

org.codehaus.plexus.util.Expand

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.codehaus.plexus.util.Expand.extractFile(File, File, InputStream, String, Date, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 153 Medium
Exceptional return value of java.io.File.setLastModified(long) ignored in org.codehaus.plexus.util.Expand.extractFile(File, File, InputStream, String, Date, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 181 Medium

org.codehaus.plexus.util.FastMap

Bug Category Details Line Priority
org.codehaus.plexus.util.FastMap is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 56-949 Medium

org.codehaus.plexus.util.FastMap$EntrySet$1

Bug Category Details Line Priority
org.codehaus.plexus.util.FastMap$EntrySet$1.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 605-607 Medium

org.codehaus.plexus.util.FastMap$KeySet$1

Bug Category Details Line Priority
org.codehaus.plexus.util.FastMap$KeySet$1.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 686-688 Medium

org.codehaus.plexus.util.FastMap$Values$1

Bug Category Details Line Priority
org.codehaus.plexus.util.FastMap$Values$1.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 542-544 Medium

org.codehaus.plexus.util.FileUtils

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.util.FileUtils.copyFile(File, File, String, FileUtils$FilterWrapper[], boolean): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 2336 High
Found reliance on default encoding in org.codehaus.plexus.util.FileUtils.copyFile(File, File, String, FileUtils$FilterWrapper[], boolean): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 2337 High
Found reliance on default encoding in org.codehaus.plexus.util.FileUtils.fileAppend(String, String, String): String.getBytes() I18N DM_DEFAULT_ENCODING 433 High
Found reliance on default encoding in org.codehaus.plexus.util.FileUtils.fileRead(File, String): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 379 High
Found reliance on default encoding in org.codehaus.plexus.util.FileUtils.fileWrite(File, String, String): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 510 High
Found reliance on default encoding in org.codehaus.plexus.util.FileUtils.loadFile(File): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 2393 High
org.codehaus.plexus.util.FileUtils.deleteFile(File) forces garbage collection; extremely dubious except in benchmarking code PERFORMANCE DM_GC 1501 High
org.codehaus.plexus.util.FileUtils.FS isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 146 High
Possible null pointer dereference in org.codehaus.plexus.util.FileUtils.cleanDirectoryOnExit(File) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 1584 Medium
Possible null pointer dereference in org.codehaus.plexus.util.FileUtils.copyDirectoryStructure(File, File, File, boolean) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 2163 Medium
Possible null pointer dereference in org.codehaus.plexus.util.FileUtils.sizeOfDirectory(File) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 1779 Medium
Redundant nullcheck of extension, which is known to be non-null in org.codehaus.plexus.util.FileUtils.isValidFile(String, String[]) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 685 Medium
Bad attempt to compute absolute value of signed random integer in org.codehaus.plexus.util.FileUtils.createTempFile(String, String, File) CORRECTNESS RV_ABSOLUTE_VALUE_OF_RANDOM_INT 2283 High
Exceptional return value of java.io.File.mkdirs() ignored in org.codehaus.plexus.util.FileUtils.copyDirectoryLayout(File, File, String[], String[]) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 2093 Medium
Exceptional return value of java.io.File.delete() ignored in org.codehaus.plexus.util.FileUtils.fileDelete(String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 543 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.codehaus.plexus.util.FileUtils.mkDirs(File, String[], File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 1051 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.codehaus.plexus.util.FileUtils.mkdir(String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 725 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.codehaus.plexus.util.FileUtils.mkdirsFor(File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 1253 Medium

org.codehaus.plexus.util.IOUtil

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.util.IOUtil.copy(InputStream, Writer, int): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 228 High
Found reliance on default encoding in org.codehaus.plexus.util.IOUtil.copy(Reader, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 370 High
Found reliance on default encoding in org.codehaus.plexus.util.IOUtil.copy(String, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 453 High

org.codehaus.plexus.util.MatchPattern

Bug Category Details Line Priority
org.codehaus.plexus.util.MatchPattern.getTokenizedPathChars() may expose internal representation by returning MatchPattern.tokenizedChar MALICIOUS_CODE EI_EXPOSE_REP 111 Medium
org.codehaus.plexus.util.MatchPattern.getTokenizedPathString() may expose internal representation by returning MatchPattern.tokenized MALICIOUS_CODE EI_EXPOSE_REP 106 Medium

org.codehaus.plexus.util.PathTool

Bug Category Details Line Priority
org.codehaus.plexus.util.PathTool.buildRelativePath(String, String, char) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 472 Medium

org.codehaus.plexus.util.ReaderFactory

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.util.ReaderFactory.newPlatformReader(File): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 163 High
Found reliance on default encoding in org.codehaus.plexus.util.ReaderFactory.newPlatformReader(InputStream): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 149 High
Found reliance on default encoding in org.codehaus.plexus.util.ReaderFactory.newPlatformReader(URL): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 177 High

org.codehaus.plexus.util.StringOutputStream

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.util.StringOutputStream.write(int): new String(byte[]) I18N DM_DEFAULT_ENCODING 52 High
Found reliance on default encoding in org.codehaus.plexus.util.StringOutputStream.write(byte[]): new String(byte[]) I18N DM_DEFAULT_ENCODING 38 High
Found reliance on default encoding in org.codehaus.plexus.util.StringOutputStream.write(byte[], int, int): new String(byte[], int, int) I18N DM_DEFAULT_ENCODING 44 High

org.codehaus.plexus.util.StringUtils

Bug Category Details Line Priority
Dead store to sz in org.codehaus.plexus.util.StringUtils.indexOfAny(String, String[]) STYLE DLS_DEAD_LOCAL_STORE 305 Medium

org.codehaus.plexus.util.WriterFactory

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.util.WriterFactory.newPlatformWriter(File): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 149 High
Found reliance on default encoding in org.codehaus.plexus.util.WriterFactory.newPlatformWriter(OutputStream): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 135 High

org.codehaus.plexus.util.cli.CommandLineUtils

Bug Category Details Line Priority
org.codehaus.plexus.util.cli.CommandLineUtils.getSystemEnvVars(boolean) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 384 Medium

org.codehaus.plexus.util.cli.Commandline

Bug Category Details Line Priority
org.codehaus.plexus.util.cli.Commandline.clone() does not call super.clone() BAD_PRACTICE CN_IDIOM_NO_SUPER_CALL 569-573 Medium
Load of known null value in org.codehaus.plexus.util.cli.Commandline.execute() STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 660 Medium

org.codehaus.plexus.util.cli.Commandline$Argument

Bug Category Details Line Priority
org.codehaus.plexus.util.cli.Commandline$Argument.getParts() may expose internal representation by returning Commandline$Argument.parts MALICIOUS_CODE EI_EXPOSE_REP 809 Medium

org.codehaus.plexus.util.cli.StreamPumper

Bug Category Details Line Priority
Found reliance on default encoding in new org.codehaus.plexus.util.cli.StreamPumper(InputStream, PrintWriter, StreamConsumer): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 118 High

org.codehaus.plexus.util.cli.shell.Shell

Bug Category Details Line Priority
org.codehaus.plexus.util.cli.shell.Shell.clone() does not call super.clone() BAD_PRACTICE CN_IDIOM_NO_SUPER_CALL 388-392 High

org.codehaus.plexus.util.introspection.MethodMap

Bug Category Details Line Priority
Switch statement found in org.codehaus.plexus.util.introspection.MethodMap.getMostSpecific(List, Class[]) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 163-183 Medium

org.codehaus.plexus.util.reflection.Reflector

Bug Category Details Line Priority
Redundant nullcheck of method, which is known to be non-null in org.codehaus.plexus.util.reflection.Reflector.invoke(Object, String, Object[]) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 177 Medium
Redundant nullcheck of method, which is known to be non-null in org.codehaus.plexus.util.reflection.Reflector.invokeStatic(Class, String, Object[]) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 315 Medium
Redundant nullcheck of con, which is known to be non-null in org.codehaus.plexus.util.reflection.Reflector.newInstance(Class, Object[]) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 76 Medium

org.codehaus.plexus.util.xml.XmlUtil

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.util.xml.XmlUtil.prettyFormat(InputStream, OutputStream, int, String): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 241 High

org.codehaus.plexus.util.xml.Xpp3Dom

Bug Category Details Line Priority
Dead store to size in org.codehaus.plexus.util.xml.Xpp3Dom.getChildren(String) STYLE DLS_DEAD_LOCAL_STORE 233 Medium

org.codehaus.plexus.util.xml.pull.MXParser

Bug Category Details Line Priority
Dead store to prefix in org.codehaus.plexus.util.xml.pull.MXParser.parseAttribute() STYLE DLS_DEAD_LOCAL_STORE 2439 Medium
Dead store to piTargetEnd in org.codehaus.plexus.util.xml.pull.MXParser.parsePI() STYLE DLS_DEAD_LOCAL_STORE 3136 Medium
org.codehaus.plexus.util.xml.pull.MXParser.getTextCharacters(int[]) may expose internal representation by returning MXParser.buf MALICIOUS_CODE EI_EXPOSE_REP 954 Medium
org.codehaus.plexus.util.xml.pull.MXParser.getTextCharacters(int[]) may expose internal representation by returning MXParser.pc MALICIOUS_CODE EI_EXPOSE_REP 948 Medium
Comparison of String objects using == or != in org.codehaus.plexus.util.xml.pull.MXParser.lookuEntityReplacement(int) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 2861 Medium
org.codehaus.plexus.util.xml.pull.MXParser.lookupNameChar should be both final and package protected MALICIOUS_CODE MS_FINAL_PKGPROTECT 3834 Medium
org.codehaus.plexus.util.xml.pull.MXParser.lookupNameStartChar should be both final and package protected MALICIOUS_CODE MS_FINAL_PKGPROTECT 3832 Medium
org.codehaus.plexus.util.xml.pull.MXParser.NCODING should be package protected MALICIOUS_CODE MS_PKGPROTECT 3159 Medium
org.codehaus.plexus.util.xml.pull.MXParser.NO should be package protected MALICIOUS_CODE MS_PKGPROTECT 3165 Medium
org.codehaus.plexus.util.xml.pull.MXParser.TANDALONE should be package protected MALICIOUS_CODE MS_PKGPROTECT 3161 Medium
org.codehaus.plexus.util.xml.pull.MXParser.VERSION should be package protected MALICIOUS_CODE MS_PKGPROTECT 3157 Medium
org.codehaus.plexus.util.xml.pull.MXParser.YES should be package protected MALICIOUS_CODE MS_PKGPROTECT 3163 Medium

org.codehaus.plexus.util.xml.pull.MXSerializer

Bug Category Details Line Priority
Found reliance on default encoding in org.codehaus.plexus.util.xml.pull.MXSerializer.setOutput(OutputStream, String): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 437 High
Comparison of String parameter using == or != in org.codehaus.plexus.util.xml.pull.MXSerializer.endTag(String, String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 909 High
Comparison of String parameter using == or != in org.codehaus.plexus.util.xml.pull.MXSerializer.checkInterning(String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 117 Medium
Comparison of String objects using == or != in org.codehaus.plexus.util.xml.pull.MXSerializer.startTag(String, String) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 744 Medium
Comparison of String objects using == or != in org.codehaus.plexus.util.xml.pull.MXSerializer.writeNamespaceDeclarations() BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 855 Medium
org.codehaus.plexus.util.xml.pull.MXSerializer.precomputedPrefixes should be package protected MALICIOUS_CODE MS_PKGPROTECT 106 Medium
Redundant nullcheck of prefix, which is known to be non-null in org.codehaus.plexus.util.xml.pull.MXSerializer.setPrefix(String, String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 524 Medium

org.codehaus.plexus.util.xml.pull.XmlPullParser

Bug Category Details Line Priority
org.codehaus.plexus.util.xml.pull.XmlPullParser.TYPES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 287 Medium